fix(records): use header login URL in restricted files notice#807
Closed
TahaKhan998 wants to merge 1 commit into
Closed
fix(records): use header login URL in restricted files notice#807TahaKhan998 wants to merge 1 commit into
TahaKhan998 wants to merge 1 commit into
Conversation
TahaKhan998
force-pushed
the
fix/issue-798-restricted-record-login-link
branch
from
9308664 to
24b4e87
Compare
kpsherva
reviewed
Jun 9, 2026
| display_name=display_name) }} | ||
| {%- endblock record_file_list -%} | ||
|
|
||
| {%- block record_files -%} |
Contributor
There was a problem hiding this comment.
about this one, I have a feeling that we add a lot of code to maintain. Could we have it in RDM instead so we don't need to override this big chunk of a block? it can decrease maintenance effort on CDS side (please check with f.e. @slint first if Zenodo needs this too)
Author
There was a problem hiding this comment.
After discussing with Alex, I’ve moved this fix upstream to invenio-rdm-records instead of overriding the block here.
Upstream PR: inveniosoftware/invenio-rdm-records#2360
I am closing this PR.
TahaKhan998
force-pushed
the
fix/issue-798-restricted-record-login-link
branch
from
4bee510 to
cd68a9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #798
When you're logged out and view a public record with restricted files, the "Log in" link in the red Files notice goes to /account/settings/login instead of the normal login page. This PR fixes that in detail.html by using the same login URL as the header button , so both links go to /login/?next=....